Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31308 )
Change subject: mainboard/emulation: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 4: Code-Review-1
(2 comments)
Saving 511 bytes on the default build for a target that does not have a flash chip seems rather pointless to me IMHO.
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG@11 PS3, Line 11: should work fine. So this driver option is not required and could be disabled.
Done.
I checked said Intel driver's source code (src/drivers/intel/wifi) and it mainly adds data to ACPI tables and applies some quirks on a certain card series. I am pretty sure even PCI passthrough would need this driver.
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig File src/mainboard/emulation/Kconfig:
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig@24 PS3, Line 24: default n
I updated the reasoning and also checked how much we win by disabling this config alone. […]
I am pretty sure nobody will ever need 511 extra bytes on QEMU using defaults...