Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60385 )
Change subject: soc/mediatek/mt8186: Add header files to support DRAM calibration ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
PS2: IMO CB:60318 could be merged into this patch.
File src/soc/mediatek/mt8186/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/60385/comment/65fa70ec_03d4f225 PS2, Line 59: struct dramc_param_header {
I think we can upstream this version first, which is used for DRAM full calibration. […]
Okay, but please add the 'config' field here first. Otherwise there will be incompatible changes.
https://review.coreboot.org/c/coreboot/+/60385/comment/d110b417_54bb220e PS2, Line 149: int validate_dramc_param(const void *blob); : int is_valid_dramc_param(const void *blob); These 2 don't exist in common/dramc_param.c, and they are not called either.