Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63593 )
Change subject: mb/google/nipperkin: Disable PSPP for WLAN ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63593/comment/f326bdce_86c81773 PS1, Line 16: Disable
Can you add a b/ explaining why?
Done.
https://review.coreboot.org/c/coreboot/+/63593/comment/937a73cb_59fcaa89 PS1, Line 17: memset(dxio_descriptors[WLAN].port_params, 0,
should this only be done for board_version >= 3 or for all board revisions? […]
We do not fully understand the root cause of the failure, so I'm hesitant to apply the change to older board versions without more testing, especially since older board versions disable L1SS.
I'm not convinced loop is better here, but I'm open to arguments.
https://review.coreboot.org/c/coreboot/+/63593/comment/2302e8fa_2816d467 PS1, Line 18: sizeof(dxio_descriptors[WLAN].port_params));
Do we also need it for Dewatt since it is not far behind?
TBD after testing. DeWatt uses a different WiFi card.