[coreboot-gerrit] Change in ...coreboot[master]: device/pci: Rewrite PCI MMCONF with symbol reference

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31752 )

Change subject: device/pci: Rewrite PCI MMCONF with symbol reference
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h 
File src/include/device/pci_mmio_cfg.h:

https://review.coreboot.org/#/c/31752/4/src/include/device/pci_mmio_cfg.h@29 
PS4, Line 29: };
> Thanks. CB:31945 seems to have a similar effect, minus the […]

I was mostly looking towards eliminating any possible arguments why using 'struct device *dev' in romstage would be a regression in code density, that's how I came across this aliasing happening in the first place.

I spent way too much messing around with this, just to realise AGESA vendorcode conveniently leaked -fno-strict-aliasing to CFLAS.