Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32131 )
Change subject: arch/x86/smbios: Add type 7
......................................................................
Patch Set 5:
Patch Set 4: Code-Review+1
There's a lot of "magic numbers", but I don't see an easy way to replace them without making expressions huge (beyond 80 characters). Still, if possible, I would like to see shift values and masks converted to literals. You might have to break lines into multiple lines (due to 80 characters limit). That's the only reason I'm not going for a +2.
I don't care about CPUID, as I saw many other examples using magic numbers. I only care about shifts, masks, and values that are publicly available on the WEB. If a value is only on NDA documents, it's OK to have magic numbers.
Done. Added more macros and replaced magic numbers.
Tested on Lenovo T520, still works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80ed25b8f2c7b425136b2f0c755324a8f5d1636d
Gerrit-Change-Number: 32131
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Sven Schnelle
svens@stackframe.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 08 Apr 2019 13:54:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment