Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61719 )
Change subject: src/soc/intel/common/block/i2c: Use early BAR in ENV_PAYLOAD_LOADER
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/soc/intel/common/block/i2c/i2c.c:
https://review.coreboot.org/c/coreboot/+/61719/comment/1d33724e_b6a1ca64
PS2, Line 135: pci_read_config32
@Tim, what is the difference between reading from config space and `probe_resourece` ? Are not both referring to the PCI config space to see if device has BAR assigned ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ab599199592a72ae96cd9f95accfaa0d84e66b6
Gerrit-Change-Number: 61719
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Feb 2022 08:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment