[coreboot-gerrit] [S] Change in coreboot[main]: src/device: Add more condition to check valid PCI device id

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Wonkyu Kim.

Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )

Change subject: src/device: Add more condition to check valid PCI device id
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84228/comment/4e51ec53_e96571ba?usp... :
PS2, Line 12: Below are invalid PCI device id cases
            : VID: 0x0 or 0xffff
            : DID: 0x0 or 0xffff
can you please highlight why some device missed to update VID/DID. Best to my knowledge it only happens for simics device and not actual device.

what is the problem that you have faced here ? looking at the existing code, I felt it only checks for VID and not DID. Are you seeing some issue when VID is valid but DID is zero/0xff?