Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )
Change subject: soc/intel/skylake/romstage: Increase size of postcar stack ......................................................................
Patch Set 2:
I am afraid I don't understand how this would have helped here. The change was submitted after about two days of inactivity, without any negative code-review scores. Wouldn't the bot have submitted the change right away, even if there are unresolved comments?
The idea is that you can actually see that the patch is about to go in. The author has to manually mark it Commit-Ready. It's a clear signal that the discussion is considered over and anyone who disagrees can intervene and stop the process (e.g. by setting a -1 or something that stops the bot). Right now the way it works is that someone +2s the patch, someone else has another comment and then it's unclear whether the author still wants to change something due to that comment or the patch is going to get merged as is. (Also, I think in general it's just nicer when users trigger submission for their own patches... it allows you to hold back if you think of something you still wanna change after you uploaded it.)
IMHO, the -1 is used too little. It's a very nice balance - doesn't block, but is visible right away (red sticks out significantly). Sure, it is "volatile" (gets lost on a new patchset), but so is a +2.
I guess, but people just don't use it that way in practice. I think it just feels too aggressive for most people.