build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ......................................................................
Patch Set 1:
(18 comments)
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 250: case SKU_0_EKKO: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 250: case SKU_0_EKKO: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 251: case SKU_1_EKKO: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 251: case SKU_1_EKKO: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 252: case SKU_2_EKKO: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 252: case SKU_2_EKKO: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 253: case SKU_3_EKKO: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 253: case SKU_3_EKKO: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 254: case SKU_0_BARD: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 254: case SKU_0_BARD: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 255: case SKU_1_BARD: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 255: case SKU_1_BARD: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 256: case SKU_2_BARD: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 256: case SKU_2_BARD: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 257: case SKU_3_BARD: code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 257: case SKU_3_BARD: please, no spaces at the start of a line
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 258: pl2_id = PL2_ID_BARD_EKKO; code indent should use tabs where possible
https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/... PS1, Line 258: pl2_id = PL2_ID_BARD_EKKO; please, no spaces at the start of a line