27 Aug
2024
27 Aug
'24
2:30 a.m.
Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84008?usp=email )
Change subject: libpayload: Use defined length movs ......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/arch/x86/pt.S:
https://review.coreboot.org/c/coreboot/+/84008/comment/98777ebc_da7b26fe?usp... : PS3, Line 132: mov %eax, (%rsi, %rcx, 8) : mov %ebx, 4(%rsi, %rcx, 8)
I guess because the actual problematic lines were the `mov $0...` ones […]
@arthur@aheymans.xyz ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84008?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fabe7fbe3f8afac5c1128debf2e09a484f26fc5
Gerrit-Change-Number: 84008
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 27 Aug 2024 00:30:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com