Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43294 )
Change subject: mb/google/dedede: Change HDMI DDC GPIOs to native function
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG@9
PS2, Line 9: HDMI DDC gpios were configured as NC till now in waddledoo.
: This may cause HDMI i2c transfer to break and EDID read may fail if
: FSP doesn't configure these GPIOs properly.
Please re-flow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/43294/2//COMMIT_MSG@11
PS2, Line 11: FSP doesn't configure these GPIOs properly
Was that observed in practice? Is that an FSP bug?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If02f062132d7c3b01b07ea9401e81f451df35c3c
Gerrit-Change-Number: 43294
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Kirtika Ruchandani
kirtika@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jul 2020 07:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment