[coreboot-gerrit] [XS] Change in coreboot[main]: drivers/i2c/generic: Remove erroneous acpigen_pop_len

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84197?usp=email )

Change subject: drivers/i2c/generic: Remove erroneous acpigen_pop_len
......................................................................

drivers/i2c/generic: Remove erroneous acpigen_pop_len

There are one too many acpigen_pop_len calls in the code
to generate the ROTM; remove one to fix an EMERG warning:
    [EMERG] ASSERTION_ERROR: file `src/acpi/acpigen.c`, line 38

The extra acpigen_pop_len() call was added commit
45d2c3d5436e ("i2c/drivers/generic: Return ROTM in a package").

Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b
Signed-off-by: Sean Rhodes 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84197
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
---
M src/drivers/i2c/generic/generic.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index 27bef49..260ea83 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -165,7 +165,6 @@
    	acpigen_write_return_namestr("RBUF");

acpigen_pop_len();
-		acpigen_pop_len();
    }

/* Chip Direct Mapping */