Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Make hfsts1 common & add helper functions
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block...
PS17, Line 258: set_host_ready
There are two types of CSR register VIZ: HOST_CSR & CSE_CSR register. […]
Done
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block...
PS17, Line 525: csr = read_host_csr();
: csr |= (CSR_RESET | CSR_IG);
: write_host_csr(csr);
The function name itself indicates triggering reset. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5c12b7abdb27c38af74ea6ee568b42ec74bcb3c
Gerrit-Change-Number: 35226
Gerrit-PatchSet: 17
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Sep 2019 11:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment