Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, ritul guru.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83777?usp=email )
Change subject: soc/amd/common/psp_smi_flash: implement SPI read/wrire/erase command
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/psp/psp_smi_flash.c:
https://review.coreboot.org/c/coreboot/+/83777/comment/4283afdc_34700c98?usp... :
PS1, Line 237: }
do we need to mark the spi controller as busy when we're using it? If not, what keeps something else […]
this code is in smm, so when that code gets interrupted, we have much larger issues, since the smm code isn't expected to ever be interrupted. i'll add something to the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83777?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4957a6d316015cc7037acf52facb6cc69188d446
Gerrit-Change-Number: 83777
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 06 Aug 2024 16:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com