Attention is currently required from: Felix Singer, Nico Huber, Martin Roth, Tim Wawrzynczak, Mario Scheithauer, Werner Zeh.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49443 )
Change subject: mb/siemens/chili: do UART pad configuration at board-level
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/siemens/chili/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49443/comment/06ec9c41_8ab84ae9
PS5, Line 6: __weak void variant_configure_bootblock_gpios(void)
: {
: }
I would say that depends on the point of view. […]
I had checked how the braces are done in other places and this is how it's usually done :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad40b6315a29e7aea612a3e1a169372d296d1d6c
Gerrit-Change-Number: 49443
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 18:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment