Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83841?usp=email )
Change subject: soc/intel/adl: update libgx config to a generic eSOL config
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83841/comment/126bad63_5a7491c9?usp... :
PS1, Line 7: update libgx config to a generic eSOL config
:
: This patch updates the early libgfx init configuration used for
: alderlake SOC with a generic Chrome early sign of life configuration.
we are binding early GFX initialization with a use case Kconfig (CHROMEOS_ENABLE_ESOL) rather the underlying technology config (MAINBOARD_HAS_EARLY_LIBGFXINIT). Ideally we don't expect to see any change in the binary or system behavior w/ and w/o this CL.
May be commit msg should reflect that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83841?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc1b9190ac0e4d25f3c5517d74c9b519bc3bb349
Gerrit-Change-Number: 83841
Gerrit-PatchSet: 1
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 09 Aug 2024 05:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes