[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Remove redundant ACPI S3 test

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27276 )

Change subject: soc/amd/common: Remove redundant ACPI S3 test
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/27276/4/src/soc/amd/stoneyridge/Kconfig 
File src/soc/amd/stoneyridge/Kconfig:

https://review.coreboot.org/#/c/27276/4/src/soc/amd/stoneyridge/Kconfig@a53 
PS4, Line 53:
> Also, I plan to reuse that s3_resume.c with improved stage_cache and mrc_cache code with agesa/family16 that definetly can do fastboot...

The stage_cache/mrc_cache is definitely a plus.  ST and I assume CZ(MF) can't do an S5 fastboot because there's now the PMU handling that DRAM training.  It doesn't know how to reuse info from a prior boot.  I believe Family 15h Mod 60h was where that first showed up; I don't believe Kavari, but definitely no F16h I've ever heard of.