Attention is currently required from: Karthik Ramasubramanian, Paul Menzel, Shelley Chen, Subrata Banik.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84185?usp=email )
Change subject: mb/google/brox: Increase PL1 Min and remove PL4 modification ......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS3:
Make it two patches?
Both PL1 and PL4 are part of cpu_power_limits(performance_efficient_limits) structure - so I would prefer to keep it in a single patch
Commit Message:
https://review.coreboot.org/c/coreboot/+/84185/comment/80ff034b_5fa658f2?usp... : PS3, Line 7: .
Please remove the dot/period.
Done
https://review.coreboot.org/c/coreboot/+/84185/comment/6bd6169c_577c42a4?usp... : PS3, Line 7: Update
More specific: Increase
Done
https://review.coreboot.org/c/coreboot/+/84185/comment/a1764888_270a8ce6?usp... : PS3, Line 10: Remove PL4 value modification based on : PsysPL3 value. :
Why?
cpu_power_limits values are fixed for brox they should not be changed unless there is a special case like low battery or no battery scenario.