Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44455 )
Change subject: mb/google/volteer/halvor: Skip fw_config override on Halvor.
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
@Googler, this project is for demo only. We don't want to compromise the real project. So we don't want add more fw_config or override function on this.
FW_CONFIG is already a config option. we probably just need to disable
it on variants where it is not required.
volteer and volteer2 (the actual boards) need it but there are several
variants that do not because they only have a single pre-determined
config for audio, usb, etc.
do you plan to have multiple audio/sd/usb configs on halvor that would
need runtime selection using fw_config?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie644ed2b95d0e355f91d92f0b3c4ce14cd4afa98
Gerrit-Change-Number: 44455
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 14 Aug 2020 04:19:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment