Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38479 )
Change subject: mb/google/puff: Add ac/dc loadline configuations ......................................................................
Patch Set 3:
(4 comments)
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38479/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38479/2//COMMIT_MSG@7 PS2, Line 7: puff
Already in the prefix.
Done
https://review.coreboot.org/c/coreboot/+/38479/2//COMMIT_MSG@9 PS2, Line 9: VRTT
What does this stand for?
It means VR test tool. VR: voltage regulator.
https://review.coreboot.org/c/coreboot/+/38479/2//COMMIT_MSG@10 PS2, Line 10: in puff device tree.
Some words fit on line above (75 characters).
Done
https://review.coreboot.org/c/coreboot/+/38479/2//COMMIT_MSG@11 PS2, Line 11:
Did it boot up before also?
Add detail steps for test item.