Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69505?usp=email )
Change subject: arch/x86/Kconfig: Move AMD stages arch to common code
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Okay. Could explain the reason? From the commit message, this patch looks like refactoring-only patch.
Also, the `ARCH_ALL_STAGES_X86_32` name is misleading, because on AMD not all stages are x86_32 even if `ARCH_ALL_STAGES_X86_32=y`.
I suppose I didn't explain this in the commit message. I was working on getting both 64bit working on this platform as well as getting clang working across all platfoms. So unless there are problems with building ARM verstage with clang, I'd like to keep that option.
The name is only somewhat misleading as all stages can run in principle on x86 except that if you enable VBOOT verstage can be an ARM stage on chromeos platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I126801a1f6f523435935bb300f3e2807db347f63
Gerrit-Change-Number: 69505
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 11:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com