Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31370 )
Change subject: [WIP] console: Split loglevel for fast and slow ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31370/1/src/console/init.c File src/console/init.c:
https://review.coreboot.org/#/c/31370/1/src/console/init.c@73 PS1, Line 73: return 0;
I think you may also want to return 0 here if CONFIG_CBMEM_CONSOLE is not enabled, so you don't wast […]
Something like that, yes, but simply returning 0 here would wipe out slow consoles entirely.
https://review.coreboot.org/#/c/31370/1/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/#/c/31370/1/src/console/printk.c@34 PS1, Line 34: console_tx_byte(byte);
Note that this seems to get called directly in some cases (looks like output from some old Intel MRC […]
Yes, old intel MRC. Sadly logging is an on/off situation here, like with FSP using console_line(); neither exposes loglevels. So for the imaginary thing of having FSP builds with debugging available, we cannot make this fast/slow console logging split unless we improve the API further.