HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44
PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
DSDT revision is not ACPI_FADT_REV_ACPI_xx... […]
used values are 1 or 2 (or grater, but same as 2)
for legacy ACPI : 1 and for current it is 2.
in fact, I want make the difference between ACPI version and DSDT rev.
(see also https://review.coreboot.org/c/coreboot/+/45786 )
is this ok ? :
#define ACPI_LEGACY_DSDT_REV 1
#define ACPI_CURRENT_DSDT_REV 2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040
Gerrit-Change-Number: 45751
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 11:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment