[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines
......................................................................

Patch Set 3:
> Patch Set 2:
>
> (1 comment)
> > Patch Set 2: Code-Review-1
> >
> > (1 comment)
> >
> > extraneous/redundant uses of the Offset() are not needed :
> > OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
> > Field (OPR1)
> > {
> >     Offset (0),     // Never needed
> >     FLD1, 32,
> >     Offset (4),     // Redundant, offset is already 4 (bytes)
> >     FLD2, 8,
> >     Offset (64),    // OK use of Offset.
> >     FLD3, 16,
> >
> > }
> >
> > will give :
> >
> > dsdt.asl     14:         Offset (0),
> > Remark   2158 -                 ^ Unnecessary/redundant use of Offset
> > operator
> >
> > dsdt.asl     16:         Offset (4),
> > Remark   2158 -                 ^ Unnecessary/redundant use of Offset
> > operator
>
> I don't see such warnings anywhere: https://paste.flashrom.org/view.php?id=3337

nano +267 Makefile.inc ;)