Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: Make MP init timeout configurable ......................................................................
Patch Set 1:
(3 comments)
No Kconfig option is needed, just increase the time-out.
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38546/1//COMMIT_MSG@7 PS1, Line 7: Make MP init timeout configurable Please add a prefix:
cpu/x86: …
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/Kconfig File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/Kconfig@192 PS1, Line 192: Time-out (in micro seconds) to wait for APs to check-in 1. No second tab. 2. Dot/period at the end please.
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/1/src/cpu/x86/mp_init.c@525 PS1, Line 525: const int timeout_us = CONFIG_FLIGHT_PLAN_TIMEOUT_US;
Why not simply increase the timeout for all targets instead of adding […]
Agreed.