Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44366 )
Change subject: soc/intel/skylake: Add PEG device definitions to pci_devs.h
......................................................................
Patch Set 4:
(1 comment)
Would be nice to guard these so that we don't use them on LP SKUs
Good idea. Will do this in another patch, since we also need to guard soc_peg_init_params() then.
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44366/3//COMMIT_MSG@7
PS3, Line 7: defintions
defin*i*tions
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44366
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2453425f44e2b4abd5566f454ae68b704dbc33e
Gerrit-Change-Number: 44366
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Aug 2020 06:10:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment