Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )
Change subject: mb/purism/librem_skl: guard selection of GMA presence straps
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_skl/Kconfig:
https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem...
PS1, Line 5: select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT
does it make sense to have that option selectable and not do anything? I'm not opposed to your solut […]
We won't use it. But the other boolean options are already outside the
if for the same reason. CB:43491 should go in anyway, IMHO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd
Gerrit-Change-Number: 43489
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 09:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment