Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32770 )
Change subject: post_code: add post code for failure to load next stage ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32770/1/src/include/console/post_codes.h File src/include/console/post_codes.h:
https://review.coreboot.org/#/c/32770/1/src/include/console/post_codes.h@326 PS1, Line 326: xE
hex constants seem to be lower case in this file (aside from AGESA ones below). […]
Done
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@166 PS3, Line 166: die("Ramstage was not loaded!\n");
why isn't it used here?
For this specific CL, we are introducing POST_INVALID_ROM and this error scenario would be related to RAM (instead of ROM).
I don't think CL should modify this die statement
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@199 PS3, Line 199: die("Unsupported payload type.\n");
why isn't it used here?
This appears to be in ramstage so INVALID_ROM seems inappropriate
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@205 PS3, Line 205: die("Payload not loaded.\n");
why isn't it used here?
This appears to be in ramstage so INVALID_ROM seems inappropriate