Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21178 )
Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c:
https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@... PS2, Line 266: struct southbridge_intel_bd82x6x_config *config = NULL; : u8 *old_hotplug_map = NULL; you could initialise them here instead of in the loop?
https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@... PS2, Line 286: config = dev->chip_info; : old_hotplug_map = config->pcie_hotplug_map; doesn't need to be in the loop?
you might want to check if config is NULL
https://review.coreboot.org/#/c/21178/2/src/southbridge/intel/bd82x6x/pch.c@... PS2, Line 297: ( no need for parentheses.