Maciej Matuszczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Patch Set 1:
(3 comments)
I guess you messed up with git, but here are some comments about the gpio.c file.
yea fixed that
https://review.coreboot.org/c/coreboot/+/35864/1/src/mainboard/lenovo/t60/va... File src/mainboard/lenovo/t60/variants/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/1/src/mainboard/lenovo/t60/va... PS1, Line 30: .gpio21 = GPIO_MODE_GPIO, /* LCD_PRESENCE */ This is R60, not T60. Yes, I do have schematics for R60. This is LCD_PRESENCE and this is output.
https://review.coreboot.org/c/coreboot/+/35864/1/src/mainboard/lenovo/t60/va... PS1, Line 82: * SMB_3B_EN */
Also not true. […]
According to my schematics, GPIO34 is output, and connects to SMB_3B_EN through R814
https://review.coreboot.org/c/coreboot/+/35864/1/src/mainboard/lenovo/t60/va... PS1, Line 102: .gpio33 = GPIO_LEVEL_LOW, : .gpio35 = GPIO_LEVEL_HIGH,
This is meaningless as those are not configured as GPIO's
oops