[coreboot-gerrit] [M] Change in coreboot[main]: commonlib/bsd: Add strnlen() and strlen() functions

[Maximilian Brune (Code Review)]

Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu.

Maximilian Brune has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )

Change subject: commonlib/bsd: Add strnlen() and strlen() functions
......................................................................

Patch Set 1:

(1 comment)

File payloads/libpayload/libc/string.c:

https://review.coreboot.org/c/coreboot/+/83830/comment/d88515a2_685329cc?usp... :
PS1, Line 71: /* NULL and empty strings have length 0. */
            : 	if (!str)
            : 		return 0;
You don't have this NULL check in the commonlib implementation. If you are unlucky a payload actually calls these functions with a possible NULL value. That would break the payloads if they did depend on that fact before this patch.