Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 4: Code-Review+2
Patch Set 1:
Patch Set 1:
(1 comment)
Any reason to not make this change for entire hatch family?
The diagnostics team has only requested this for 4 devices, because only one OEM asks for the newly-available information in sysfs. I still have it on my list of things to do to see if we can switch from using BAT0 to just the sbs driver 😊 This allows the diagnostics team to get away from a single, very hacky use of ectool to get at the smart battery directly.
Oh okay. I still think it might be easier to have the entire family enable the same support. But, I will let you and Shelley decide.