Attention is currently required from: Angel Pons, Máté Kukri, Paul Menzel, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/dell/optiplex_9020/sch5555_ec.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/f7ccd496_c530ade6 :
PS9, Line 8: ec_read
How about `sch555x_mbox_read`?
sch555x_mbox_read is better and more descriptive name than what i suggested
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 9
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 22 Apr 2024 20:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment