Attention is currently required from: Jonathan Zhang, Maxim Polyakov, Jingle Hsu.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39979 )
Change subject: intel/xeon_sp: add ACPI to control GPIO
......................................................................
Patch Set 43:
(2 comments)
Patchset:
PS41:
What I meant is that the controller file is not created: […]
The current kernel is the following, why we need to com2 to be included? Because of calculation?
static const struct intel_community lbg_communities[] = {
LBG_COMMUNITY(0, 0, 71),
LBG_COMMUNITY(1, 72, 132),
LBG_COMMUNITY(3, 133, 144),
LBG_COMMUNITY(4, 145, 180),
LBG_COMMUNITY(5, 181, 246),
};
File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39979/comment/296051c8_990c2353
PS43, Line 13: 1
If we have only one "INT35336" and then _UID is not needed or _UID can be 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c882077eb3c035faae81641bc860e69db224b4
Gerrit-Change-Number: 39979
Gerrit-PatchSet: 43
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Comment-Date: Sat, 16 Jan 2021 11:09:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-MessageType: comment