Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )
Change subject: soc/intel/skylake/romstage: Increase size of postcar stack
......................................................................
Patch Set 2:
Patch Set 2:
Why was it merged?
Not all comments have been processed yet?
Do I need to give -2 on everything that I comment at?
I quess this was merged because it had a +2 and was not updated for two days, so a split-second check would not notice there's pending issues. I usually give a -1 to such changes so that not everything is green (I am unworthy of -2 powers).
I agree this change was prematurely merged, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f1a4631bcadfb8c7d1de5bf0919e40990a65606
Gerrit-Change-Number: 33434
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:45:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment