Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74118 )
Change subject: mb/google/skyrim: Disable L1.2 for SD port ......................................................................
mb/google/skyrim: Disable L1.2 for SD port
Having L1.2 enabled on the SD port increases the kernel resume times by between 30 & 40ms. This patch disables L1.2 on SD to get that time back.
As with needing to have hotplug enabled on the SD card, this seems like a driver issue, so hopefully that will get sorted out and this patch can be reverted.
BUG=b:274025743 TEST=resume times are decreased. BRANCH=skyrim
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I2c409fa2cd66c712c5ba7104635499d63fa0d2be Reviewed-on: https://review.coreboot.org/c/coreboot/+/74118 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/skyrim/port_descriptors.c 1 file changed, 26 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index 30caa78..80839a0 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -35,7 +35,6 @@ .link_hotplug = 3, .link_aspm = ASPM_L1, .link_aspm_L1_1 = true, - .link_aspm_L1_2 = true, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1, },