Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85666/comment/93057c0e_bed95a48?usp... :
PS7, Line 9: Geralt
Rauru
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/f1e3df26_ed3593e4?usp... :
PS7, Line 65: (get_adc_index(SKU_ID_HIGH_CHANNEL) << 4
We don't use VIN2 for neither Rauru nor Navi
https://review.coreboot.org/c/coreboot/+/85666/comment/f62387fc_b352e767?usp... :
PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL))
@knoxchiou@google.com any suggestion for unprovisioned SKU ID ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece
Gerrit-Change-Number: 85666
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 20 Dec 2024 07:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No