Attention is currently required from: Yi Chou.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79437?usp=email )
Change subject: vboot: Add firmware PCR support
......................................................................
Patch Set 8:
(1 comment)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/79437/comment/38b3dc8f_dee374a2 :
PS8, Line 196: return vboot_extend_pcr(ctx, CONFIG_PCR_FW_VER, FIRMWARE_VERSION_PCR);
I just realized, we should probably skip this in recovery mode? In recovery mode we don't have a valid firmware version.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I601ad31e8c893a8e9ae1a9cdd27193edce10ec61
Gerrit-Change-Number: 79437
Gerrit-PatchSet: 8
Gerrit-Owner: Yi Chou
yich@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Andrey Pronin
apronin@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yi Chou
yich@google.com
Gerrit-Comment-Date: Tue, 09 Jan 2024 18:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment