Werner Zeh has posted comments on this change. ( https://review.coreboot.org/25785 )
Change subject: siemens/mc_apl1: Provide baseboard and variant concepts ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@9 PS1, Line 9: ApolloLake Add a spce: Apollo Lake
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@10 PS1, Line 10: reverence reference
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@11 PS1, Line 11: , remove this comma
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@17 PS1, Line 17: , can be removed
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@18 PS1, Line 18: , can be removed
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@25 PS1, Line 25: add themselves be added
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfi... File src/mainboard/siemens/mc_apl1/Kconfig:
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfi... PS1, Line 7: select DRIVER_INTEL_I210 I would better activate the (final) board specific switches in the variants Kconfig rather than here.
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfi... PS1, Line 10: select DRIVERS_I2C_RX6110SA : select DRIVERS_UART_8250IO dito
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 17: "baseboard/brd_gpio.h" Make this include the last one in the list.