Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41965 )
Change subject: soc/mediatek/mt8183: Enable CA perbit mechanism
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41965/9/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/41965/9/src/soc/mediatek/mt8183/dra...
PS9, Line 21: (
No need for the parentheses.
Done
https://review.coreboot.org/c/coreboot/+/41965/9/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/41965/9/src/soc/mediatek/mt8183/dra...
PS9, Line 384: for (u8 ca = 0; ca < CA_NUM_LP4; ca++)
: perbit_dly = params->cbt_ca_perbit_delay[chn][rk];
No need for the 'for' loop. Just […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58e29d0c91a469112b0b1292da80bcb802322d47
Gerrit-Change-Number: 41965
Gerrit-PatchSet: 10
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Hung-Te Lin
hungte@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 02:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment