Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31912 )
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports
......................................................................
Patch Set 1: Code-Review+1
Looks good. Maybe it is worth listing what is on each PCIe lane, such as ethernet, physical ports and such. I only have the P5QL PRO, so I am afraid I cannot test anything.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I779400494e27bf046996512d1f772311e6e4e091
Gerrit-Change-Number: 31912
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE
persmule@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Mar 2019 16:14:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment