Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52541 )
Change subject: soc/mediatek/mt8195: Add timer support
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
What is timer v1 and v2 about? Please write commit messages. […]
The timer regs have been changed starting from 8195, so we call previous gens v1 and newers v2 - just consider that as versions of implementations. We had such discussion somewhere - maybe in chromium repo? but yes next time we can provide more details in the commit description.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a87e7d5983bf14ad123de82ed670a22a7be1aa
Gerrit-Change-Number: 52541
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 19 Aug 2021 08:25:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment