Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )
Change subject: util/inteltool: Add H110 GPIO support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool
agreed
You should mention that this is about GPIO dumping, because the chipset was already known to inteltool, so I suggested to change it to either
util/inteltool/gpio: Add H110 chipset support
or
util/inteltool: Add H110 GPIO support
(I highlighted `util/inteltool` above, this is what I referred to with "adding `/gpio`". s/chipset/GPIO/ is a common command for editing tools like sed, it means s(ubstitute) chipset with GPIO)