Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 20:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34537/19/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/34537/19/src/device/pci_device.c@54 PS19, Line 54: #include <bootsplash.h> Move it up after <bootmode.h>
https://review.coreboot.org/c/coreboot/+/34537/19/src/device/pci_device.c@77... PS19, Line 776: set_vesa_bootsplash(); No preprocessor use here, just regular if (CONFIG(xxx)).
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.c File src/lib/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/17/src/lib/bootsplash.c@19 PS17, Line 19: #include "bootsplash.h"
For some reason there are a lot of headers in src/lib. […]
Done
https://review.coreboot.org/c/coreboot/+/34537/19/src/lib/bootsplash.c File src/lib/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/34537/19/src/lib/bootsplash.c@23 PS19, Line 23: void set_vesa_bootsplash()
Jenkins sees it all ^^
Done