Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66945 )
Change subject: soc/amd/mendocino: Add GSVCD range ......................................................................
Patch Set 12:
(5 comments)
File src/soc/amd/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66945/comment/e636d6cb_49769a8a PS12, Line 35: awk '/$(1)/ {print $$4}' You could do the offset and size in one command can't you?
`awk '/$(1)/ {printf("%x:%x",$$3,$$4)}'`
File src/soc/amd/mendocino/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66945/comment/ed90fa0d_9b0991d5 PS3, Line 304: grep '^$(1) ' | cut '-d ' -f3 Does `awk '$$1 == "$(1)" {print $$3}'` work?
Ah, I don't think so since $1 contains a space
https://review.coreboot.org/c/coreboot/+/66945/comment/fb3418c4_8c7ab44c PS3, Line 307: Hrm, maybe this is where you add the amdfwread dep:
``` files_added:: $(AMDFWREAD) ```
https://review.coreboot.org/c/coreboot/+/66945/comment/a2ec1e3b_b20e3df3 PS3, Line 309: offset=$$($(call amdfwread-offset-cmd,BIOSL2: 0x62)) ;\ : if [ -n "$$offset" ]; then \ : printf "%x:%x" $$offset $$($(call amdfwread-size-cmd,BIOSL2: 0x62)) ;\ : fi ;\ Should we move this out into a bash script that we just call?
File src/soc/amd/mendocino/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66945/comment/d255595c_763e94c6 PS12, Line 332: Bootblock Hrmm, does verstage not verify bootblock?