[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )

Change subject: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/43980/3/src/soc/intel/tigerlake/fsp... 
PS3, Line 123: TcssD3ColdEnable
> if we change TcssD3ColdEnable to TcssD3ColdDisable: […]

Typically soc_intel_tigerlake_config elements are aligned with fsp upd. Sure, TcssD3ColdEnable can be changed to TcssD3ColdDisable to fit params->D3ColdEnable = !!config->TcssD3ColdDisble.
But then it would need additional patches orderly across soc and mainboards in order to avoid build break because we can not simply rename TcssD3ColdEnable to TcssD3ColdDisable.