Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34287/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34287/1//COMMIT_MSG@10
PS1, Line 10: shall
It's a good goal to be able to boot the default, but there are plenty of instances when that's not t […]
Most people don't need to add ME binaries to build a coreboot.rom that boots, as they are usually on the flash chip already. But considering the situation for older FSP, as well as mrc and refcode, I think "should" fits better.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30b1808f91701c07dce6f1de08c213150e8a675a
Gerrit-Change-Number: 34287
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 12 Jul 2019 20:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment