Maccraft123 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 21:
(3 comments)
Patch Set 20:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35864/20/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/20/Documentation/mainboard/le... PS20, Line 16: # Should I include link or credit the creator? https://gist.github.com/ArthurHeymans/c5ef494ada01af372735f237f6c6adbe
https://review.coreboot.org/c/coreboot/+/35864/20/Documentation/mainboard/le... PS20, Line 36: - Several pixel black bar at the left side of screen. Doesn't appear in Linux. See picture.
Does this also happen in native res instead of textmode?
Yep. Just tested
https://review.coreboot.org/c/coreboot/+/35864/20/src/mainboard/lenovo/t60/v... File src/mainboard/lenovo/t60/variants/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/20/src/mainboard/lenovo/t60/v... PS20, Line 30: .gpio21 = GPIO_MODE_GPIO, /* LCD_PRESENCE */ IMO this would decrease readibility to someone else.