Attention is currently required from: Vinod Polimera, Shelley Chen, Hung-Te Lin, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56966 )
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/5b02d873_8553b720
PS1, Line 110: get_panel_config
Remove it from trogdor/panel_driver.c (and soc/display/panel.h)?
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/7abe827f_d54b0683
PS1, Line 247: ret
I guess it's fine to convert int return value to cb_err_t?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 13 Aug 2021 10:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
