Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: src: Use standard <inttypes.h> ......................................................................
Patch Set 10: Code-Review-1
(3 comments)
I think it's actually dangerous to implement these things for types that (currently) nobody cares about. But if we really want to cover all these types, I'm ok with it. I just fear this will have to go through some more rounds.
We should also have a common `stdint.h` ready so it's obvious that we expect a specific implementation for all supported architectures. Or maybe even discuss that one first. For instance, the spotted issue may also mean that we might want to adapt `stdint`?
https://review.coreboot.org/c/coreboot/+/33823/10/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/10/src/include/inttypes.h@202 PS10, Line 202: #define SCNoFAST8 "o" /* uint_fast8_t */ nope, our current `fast` implementation seems to match the regular one
https://review.coreboot.org/c/coreboot/+/33823/10/src/include/inttypes.h@220 PS10, Line 220: #define SCNuFAST8 "u" /* uint_fast8_t */ nope
https://review.coreboot.org/c/coreboot/+/33823/10/src/include/inttypes.h@238 PS10, Line 238: #define SCNxFAST8 "x" /* uint_fast8_t */ nope